Handle audit log paths different from defaults#10715
Handle audit log paths different from defaults#10715rsevilla87 wants to merge 1 commit intoopenshift:masterfrom rsevilla87:master
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rsevilla87 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @rsevilla87. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
|
Hostmounting arbitrary folders is a bad and dangerous idea, what's wrong with using |
|
@vrutkovs In most cases /var/log is an independent mount point and /var/lib/origin has not been sized to store logs. |
|
I'm still not sure if this is a good idea, but in any case master branch would soon be significantly reworked for 4.0 install. Please open a new PR for |
4 participants
This commit is intended to make the installer able to handle OpenShift log paths different from (/etc/origin/master, /var/lib/origin, /etc/origin/cloudprovider), which in most of cases are not appropiate since those directories are not usually used as log store.
The code included create new directory (if applies) and adds it as a hostPath in the apiserver static pod definition. The code of the custom module master_check_paths_in_config has been also properly tuned to allow this directories to be defined in the master-config.yaml